BIPST 2.1: Tomcat maxThreads not detected correctly

[mhf]

Hello 🙂

We're runnign BIPST 2.1, SAP Host Agent 7.21 SP31 and BIP 4.2 SP05 with bundled Tomcat 8.5

Issue: BIPST Web Application Analysis Report does not detect the Tomcat maxThreads parameter correctly. It shows 200 threads instead of 1500 as defined in the ..\tomcat\conf\server.xml for the standard catalina service connector.

Steps to reproduce:

1. Stop Tomcat

2. Browse to and open the ..\tomcat\conf\server.xml

3. Uncomment the connector for the standard service/connector catalina and set maxThreads to 1500.

4. Save the file.

5. Start Tomcat

6. Run the BIPST Web Application Analysis Report and check the maxThreads entry. It still shows 200 instead of 1500.

Thanks & BR,

Michael

[former_member398039]

Hi Michael,

The reason you are not seeing that change in the Web Application Server analysis report is that we currently do not retrieve that information. As per your screenshot, we make the following change in server.xml file:

<Service name="Catalina">

<!--The connectors can use a shared executor, you can define one or more named thread pools-->
<Executor name="tomcatThreadPool" namePrefix="catalina-exec-"
maxThreads="1500" minSpareThreads="4"/>

As you can see, this is under the type Executor. I see it when I open it up in jConsole under the same Executor.

Where as the setting that you are seeing under HTTP Connector (8080) is under Connector type:

We can look into adding this information in the future if it is useful. Hope that answers your question.

Best regards,

James

BI platform support tool dev team

[Toby_Johnston]

Thanks james.zhang5

According to Apache Tomcat site:

"The Executor represents a thread pool that can be shared between components in Tomcat. Historically there has been a thread pool per connector created but this allows you to share a thread pool, between (primarly) connector but also other components when those get configured to support executors"

I think in this scenario we should report the threads defined for the Executor thread pool if it's configured. Will target this for patch 1 or patch 2.

[Toby_Johnston]

Hi Michael,

The patch for this issue is released now. (2.1.1)

Cheers
Toby

[former_member398039]

Hi Michael,

We will be adding the Executor type to our Web Application Analysis Report in 2.1.1. We are looking for end of February release.

Best regards,

James

[Toby_Johnston]

Hi Michael,

Thanks for reporting the issue. Let me test this out and come back to you.

Cheers
Toby