One of worst function module released by SAP in terms of coding standard

[Former Member]

Hi ,

I have ever come across SAP function module in terms of Coding standard.

"J_1I4_GET_ACTUAL_DUTY_IN_LIV".

Please if any one knows SAP Quality team id please forward this function module to them.

I do know how SAP has released this kind of function module

Thanks

Venkat

Moderator message: moved to general discussions forum.

Edited by: Thomas Zloch on Oct 4, 2011 10:42 PM

[former_member583013]

Well...I have to agree that it's actually pretty messy code...but maybe it was done in a hurry, or to provide a quick simple solution for a particular company...if it's not released, then it means that it's supported by SAP, so it shouldn't be taken as the real thing...or maybe, it's just plain old...and they forget about it...

One funny thing is the description: Get excise value at Invoice verification They could at least written correctly -:P

Greetings,

Blag.

[Former Member]

The FM is clearly marked as "not released" and is not "remote enabled".

That it exists in your production system is one issue.

That you are wanting to actually use it as an expected API to something is another....?

Cheers,

Julius

[matt]

Not released means it's not available for customer use. But that doesn't excuse the frankly awful coding. At some point, SAP are going to have to maintain that function module. Due to the way that it's written, that's going to take some time and be expensive.OK, that's SAP's problem and cost. But it'll probably need some iterations before it works again... and that's the customers problem.

Using "not released" function modules can be quite risky. There were some in APO in use by some custom code on what site - custom code written by a SAP employee on behalf of the client - that disappeared in the next release.... whoops.

There's a huge amount of code in the SAP system. While I'm sure this will be eventually fixed - probably when it next fails - I doubt it'll be high priority.

[Jelena]

OK, that's SAP's problem and cost.

Well, ahem, where does SAP get their money from? From the customers. So eventually all the cost will be passed down to us by the means of license fees, etc.

I have also noticed though that country-specific development doesn't seem to go through the same QA or code review process as the "core" SAP. Perhaps it's something that should be looked into.

[Former Member]

While I'm sure this will be eventually fixed - probably when it next fails - I doubt it'll be high priority.

There are a number of notes correcting this FM.

Rob

[Former Member]

LoL!

[SAP Note 783224 - Rollback of the note 429073|https://service.sap.com/sap/support/notes/783224] is high priority...

Important:
The changes provided have to be applied MANUALLY. These changes cannot be applied via S Note or Note Assistant.

The comments, notes about changes and some corrections to previous notes which changed the FM (manually) mention legal requirements very often...

It is quite possible that the developer author is a lawyer

Cheers,

Julius

[Former Member]

looks like it was probably written by SAP contractor, perhaps in the country where needed for use.

[sjeevan]

Or perhaps the code reviewer wasn't doing his job. I hope SAP is not following Ford, GM and Chrysler in quality control.

[Former Member]

Hi,

I do not have any issues with this function module. Just go thru the coding standard of this function module. Simple thing do not even follow subroutine and sy-subrc check and select statement.

Thanks

[former_member182371]

Hi,

what do you propose instead?

Best regards.

[madhu_vadlamani]

Hi Venkat,

1) What is the worry about coding 2) Even you see fm which have good coding they also use same select statements to bring the data . I think there is no need to post to sap for this.

Regards,

Madhu.

[Former Member]

Dear Friend

May be In your case It Not Works Fine.......

It not means that FM is useless or worst

If there is any problem write to sap they will provide you solution.

Regards

Ajit

[Former Member]

Hi venkat,

Even if you think that there are problems in any FM.

SAP can come up with newer version of that particular FM in new Release/NOTE.

BR,

Regards,

Rahul