Skip to Content
author's profile photo Former Member
Former Member

Macros Vs Subroutine pool

Hi All,

I need to chage the code as per my company coding standards.

As per the requiremnt i am using the PERFORM statment more time to dispaly Field Catalog based on some coditions.

Statments:

PERFORM F_FIRST_FIELD_CATALOG USING C_HKONT

C_BSIS

W_COL_POS

TEXT-010

SPACE.

Add a comment
10|10000 characters needed characters exceeded

Assigned Tags

Related questions

2 Answers

  • author's profile photo Former Member
    Former Member
    Posted on Jan 29, 2008 at 02:45 PM

    hi

    hope it will help you.

    <REMOVED BY MODERATOR>

    Refer this link,it will provide u sample code for all.

    http://help.sap.com/saphelp_nw2004s/helpdata/en/9f/db979035c111d1829f0000e829fbfe/content.htm

    PERFORM - parameter_list

    Syntax

    ... [TABLES itab1 itab2 ...]

    [USING a1 a2 ...]

    [CHANGING a1 a2 ...].

    Extras:

    1. ... TABLES itab1 itab2 ...

    2. ... USING a1 a2 ...

    3. ... CHANGING a1 a2 ...

    Effect

    These additions assign actual parameters to the formal parameters from the parameter interface for the subroutine subr. You can specify all data objects whose data type matches the typing of the corresponding formal parameter (see Check Typing) as actual parameters. Each formal parameter assumes all the properties of the actual parameter assigned to it when it is called.

    Addition 1

    ... TABLES itab1 itab2 ...

    Effect

    If you specify the addition TABLES, each table parameter t1 t2 ... for the subroutine called that is defined with the addition TABLES to the FORM statement must be assigned an internal table itab as the actual parameter. The assignment of the actual parameters to the formal parameters takes place using their positions in the lists t1 t2 ... and itab1 itab2 ... .

    You can only specify standard tables for itab. Transfer takes place by means of a reference. If a specified table itab has a header line, this is also transferred; otherwise, the header line in the corresponding table parameter t is blank when it is called.

    Note

    Use of table parameters in the interface for subroutines is obsolete but a large number of subroutines have not yet been converted to appropriately typed USING or CHANGING parameters, so that they must still be supplied with data by the TABLES addition to the PERFORM statement.

    Example

    Static call of the internal subroutine select_sflight transferring a table parameter.

    PARAMETERS: p_carr TYPE sflight-carrid,

    p_conn TYPE sflight-connid.

    DATA sflight_tab TYPE STANDARD TABLE OF sflight.

    ...

    PERFORM select_sflight TABLES sflight_tab

    USING p_carr p_conn.

    ...

    FORM select_sflight TABLES flight_tab LIKE sflight_tab

    USING f_carr TYPE sflight-carrid

    f_conn TYPE sflight-connid.

    SELECT *

    FROM sflight

    INTO TABLE flight_tab

    WHERE carrid = f_carr AND

    connid = f_conn.

    ENDFORM.

    Addition 2

    ... USING a1 a2 ...

    Addition 3

    ... CHANGING a1 a2 ...

    Effect

    If you specify the additions USING and CHANGING, an actual parameter a1 a2 ... of the appropriate type must be assigned to each of the formal parameters u1 u2 ... and c1 c2 ... defined with the same additions to the FORM statement. The actual parameters specified after USING and CHANGING form one shared list. They are assigned to the formal parameters after the position in the shared list. The type of parameter transfer is defined with the additions USING and CHANGING to the FORM statement. The addition USING must be before CHANGING. Otherwise, the assignment of the actual parameters to the additions USING and CHANGING is irrelevant to the PERFORM statement. It is also irrelevant whether only one or both of the additions is specified.

    Notes

    For the sake of program documentation, we advise that you specify the additions USING and CHANGING in the FORM statement according to the definition of the parameter interface.

    In non-Unicode programs, you can address memory area outside an actual parameter if an actual parameter a1 a2 ... is assigned offset or length specifications. In non-Unicode programs, the length is set to the length of the current parameter if an offset is specified without a length. Both of these lead to warnings in the syntax check and to syntax errors in Unicode programs. The rules for the ASSIGN statement apply to the addressable memory area in non-Unicode programs as well.

    Example

    The following five PERFORM statements mean the same but only the fourth is recommended, since it is the only one that documents the interface of the subroutine called.

    DATA: a1 TYPE string,

    a2 TYPE string,

    a3 TYPE string,

    a4 TYPE string.

    PERFORM test USING a1 a2 a3 a4.

    PERFORM test CHANGING a1 a2 a3 a4.

    PERFORM test USING a1 CHANGING a2 a3 a4.

    PERFORM test USING a1 a2 CHANGING a3 a4.

    PERFORM test USING a1 a2 a3 CHANGING a4.

    ...

    FORM test USING p1 TYPE string

    p2 TYPE string

    CHANGING value(p3) TYPE string

    value(p4) TYPE string.

    ...

    ENDFORM.

    Edited by: Alvaro Tejada Galindo on Jan 29, 2008 10:07 AM

    Add a comment
    10|10000 characters needed characters exceeded

  • author's profile photo Former Member
    Former Member
    Posted on Jan 29, 2008 at 02:48 PM

    Hi Sridhar,

    Goto transaction SE30 and click the TIPS AND TRICKS button. U will get tips of performance improvement.

    hope this helps.

    Also, this will be of some help 4 u.

    pls Re-check u r code with below points.

    1) should not write any select statement in side the loop and endloop.

    2) Use Select into corresponding fields insted of select *

    3) refresh your internal tables after data is processed.

    4) use move corresponding insted of move single

    5)use type insted of like while declaring the parameters.

    6) it would be better if u use workarea

    this is from ABAP side.

    <REMOVED BY MODERATOR>

    cheers,

    Hema.

    Edited by: Alvaro Tejada Galindo on Jan 29, 2008 10:08 AM

    Add a comment
    10|10000 characters needed characters exceeded

Before answering

You should only submit an answer when you are proposing a solution to the poster's problem. If you want the poster to clarify the question or provide more information, please leave a comment instead, requesting additional details. When answering, please include specifics, such as step-by-step instructions, context for the solution, and links to useful resources. Also, please make sure that you answer complies with our Rules of Engagement.
You must be Logged in to submit an answer.

Up to 10 attachments (including images) can be used with a maximum of 1.0 MB each and 10.5 MB total.