I'm making a little bit of progress in understanding some things but not in actually getting it to work. I get now that updating an entity always requires a PUT or MERGE request with the parameters in the body, not in the URL, but I should not build the request directly (and therefore ignore the tutorial above where odata.request(...) is called), the model will take care of building the request. I found that in v2 ODataModel one calls the method submitChanges(...) but there is no method with submit in the name in the JSONModel, so not sure what to call there. I tried if just calling setData(...) might be enough but either it's not or something else is wrong.
A sample request that works with method PUT in SAP Gateway Client /n/IWFND/GW_CLIENT:
/sap/opu/odata/sap/ZMC_SAFI_GWPROJECT_SRV/ZMCSettingsSet(FioriUser='D012345')
<?xml version="1.0" encoding="utf-8"?>
<entry xml:base="https://ldcidpv.mo.sap.corp:44378/sap/opu/odata/sap/ZMC_SAFI_GWPROJECT_SRV/" xmlns="http://www.w3.org/2005/Atom" xmlns:m="http://schemas.microsoft.com/ado/2007/08/dataservices/metadata" xmlns:d="http://schemas.microsoft.com/ado/2007/08/dataservices">
<id>https://ldcidpv.mo.sap.corp:44378/sap/opu/odata/sap/ZMC_SAFI_GWPROJECT_SRV/ZMCSettingsSet('D012345')</id>
<title type="text">ZMCSettingsSet('D012345')</title>
<updated>2017-08-01T19:03:47Z</updated>
<category term="ZMC_SAFI_GWPROJECT_SRV.ZMCSettings" scheme="http://schemas.microsoft.com/ado/2007/08/dataservices/scheme"/>
<link href="ZMCSettingsSet('D012345')" rel="self" title="ZMCSettings"/>
<content type="application/xml">
<m:properties>
<d:FioriUser>D012345</d:FioriUser>
<d:LegalEntity>SLE0</d:LegalEntity>
<d:SourceSystem>ERSTE01</d:SourceSystem>
</m:properties>
</content>
</entry>
My old code where I incorrectly tried to call getData(...) with all three parameters in the URL, which resulted in the "Invalid key predicate" error in /n/IWFND/ERROR_LOG, because it's calling getEntity / read again, not updateEntity, and it supplies more than the key parameter:
sap.ui.define([
"zmc_cust/controller/BaseController",
"zmc_cust/model/formatter",
"sap/ui/model/json/JSONModel",
"sap/ui/model/Filter",
"sap/ui/model/FilterOperator",
"sap/m/MessageToast",
"sap/m/MessageBox"
], function (BaseController, formatter, JSONModel, Filter, FilterOperator, MessageToast, MessageBox) {
"use strict";
return BaseController.extend("zmc_cust.controller.Worklist", {
formatter: formatter,
onInit : function () {
var that = this;
var settingsModel = new JSONModel();
//attach function for end of asynchronous call
settingsModel.attachRequestCompleted(function() {
var legalEntity = settingsModel.getProperty("/d/LegalEntity");
var legalEntityComboBox = that.getView().byId("LegalEntityComboBox");
legalEntityComboBox.setSelectedKey(legalEntity);
legalEntityComboBox.setValue(legalEntity);
var sourceSystem = settingsModel.getProperty("/d/SourceSystem");
var sourceSystemComboBox = that.getView().byId("SourceSystemComboBox");
sourceSystemComboBox.setSelectedKey(sourceSystem);
sourceSystemComboBox.setValue(sourceSystem);
});
var userId = sap.ushell.Container.getService("UserInfo").getId();
var URI = "/sap/opu/odata/sap/ZMC_SAFI_GWPROJECT_SRV/ZMCSettingsSet(FioriUser='"+userId+"')";
settingsModel.loadData(URI);
},
onUpdateFinished : function (oEvent) {
// update the worklist's object counter after the table update
this.getModel("worklistView").setProperty("/busy", false);
},
onNavBack : function() {
var sPreviousHash = sap.ui.core.routing.History.getInstance().getPreviousHash(),
oCrossAppNavigator = sap.ushell.Container.getService("CrossApplicationNavigation");
if (sPreviousHash !== undefined || !oCrossAppNavigator.isInitialNavigation()) {
history.go(-1);
} else {
oCrossAppNavigator.toExternal({
target: {shellHash: "#Shell-home"}
});
}
},
onSavePress: function (event) {
var that = this;
var userId = sap.ushell.Container.getService("UserInfo").getId();
var keyLegalEntity = this.getView().byId("LegalEntityComboBox").getSelectedKey();
var keySourceSystem = this.getView().byId("SourceSystemComboBox").getSelectedKey();
var settingsModel = new JSONModel();
//attach function for end of asynchronous call
settingsModel.attachRequestCompleted(function() {
var legalEntity = settingsModel.getProperty("/d/LegalEntity");
var sourceSystem = settingsModel.getProperty("/d/SourceSystem");
if (event.getParameters().success) {
if (legalEntity != keyLegalEntity || keySourceSystem != sourceSystem) {
MessageBox.error("Saving failed even though the request was successful", {styleClass: "sapUiSizeCompact"});
} else {
MessageToast.show("Settings saved");
that.onNavBack();
}
}
});
settingsModel.attachRequestFailed(function() {
MessageBox.error("Saving failed due to connection or ABAP system problem", {styleClass: "sapUiSizeCompact"});
});
var URIkeyUserId = encodeURIComponent(userId);
var URIkeyLegalEntity = encodeURIComponent(keyLegalEntity);
var URIkeySourceSystem = encodeURIComponent(keySourceSystem);
var URI = "/sap/opu/odata/sap/ZMC_SAFI_GWPROJECT_SRV/ZMCSettingsSet(FioriUser='"+URIkeyUserId+"',LegalEntity='" + URIkeyLegalEntity + "',SourceSystem='" + URIkeySourceSystem + "')";
settingsModel.loadData(URI);
},
onCancelPress: function (event) {
var that = this;
this.onNavBack();
MessageToast.show("Action cancelled...");
}
});
}
);
I changed it like this (see the places with the comments in the beginning of the line), which in my understanding is coming closer to being correct ... but it's not working anyway. attachRequestCompleted() is called, but nothing was saved (error "Saving failed even though the request was successful" is shown and I can see on the database it was not updated):
sap.ui.define([
"zmc_cust/controller/BaseController",
"zmc_cust/model/formatter",
"sap/ui/model/json/JSONModel",
"sap/ui/model/Filter",
"sap/ui/model/FilterOperator",
"sap/m/MessageToast",
"sap/m/MessageBox"
], function (BaseController, formatter, JSONModel, Filter, FilterOperator, MessageToast, MessageBox) {
"use strict";
return BaseController.extend("zmc_cust.controller.Worklist", {
formatter: formatter,
onInit : function () {
var that = this;
var settingsModel = new JSONModel();
//attach function for end of asynchronous call
settingsModel.attachRequestCompleted(function() {
var legalEntity = settingsModel.getProperty("/d/LegalEntity");
var legalEntityComboBox = that.getView().byId("LegalEntityComboBox");
legalEntityComboBox.setSelectedKey(legalEntity);
legalEntityComboBox.setValue(legalEntity);
var sourceSystem = settingsModel.getProperty("/d/SourceSystem");
var sourceSystemComboBox = that.getView().byId("SourceSystemComboBox");
sourceSystemComboBox.setSelectedKey(sourceSystem);
sourceSystemComboBox.setValue(sourceSystem);
});
var userId = sap.ushell.Container.getService("UserInfo").getId();
var URI = "/sap/opu/odata/sap/ZMC_SAFI_GWPROJECT_SRV/ZMCSettingsSet(FioriUser='"+userId+"')";
settingsModel.loadData(URI);
},
onUpdateFinished : function (oEvent) {
// update the worklist's object counter after the table update
this.getModel("worklistView").setProperty("/busy", false);
},
onNavBack : function() {
var sPreviousHash = sap.ui.core.routing.History.getInstance().getPreviousHash(),
oCrossAppNavigator = sap.ushell.Container.getService("CrossApplicationNavigation");
if (sPreviousHash !== undefined || !oCrossAppNavigator.isInitialNavigation()) {
history.go(-1);
} else {
oCrossAppNavigator.toExternal({
target: {shellHash: "#Shell-home"}
});
}
},
onSavePress: function (event) {
var that = this;
var userId = sap.ushell.Container.getService("UserInfo").getId();
var keyLegalEntity = this.getView().byId("LegalEntityComboBox").getSelectedKey();
var keySourceSystem = this.getView().byId("SourceSystemComboBox").getSelectedKey();
// new parameter
var userId = sap.ushell.Container.getService("UserInfo").getId();
var URI = "/sap/opu/odata/sap/ZMC_SAFI_GWPROJECT_SRV/ZMCSettingsSet(FioriUser='"+userId+"')";
var settingsModel = new JSONModel(URI);
//attach function for end of asynchronous call
settingsModel.attachRequestCompleted(function() {
var legalEntity = settingsModel.getProperty("/d/LegalEntity");
var sourceSystem = settingsModel.getProperty("/d/SourceSystem");
if (event.getParameters().success) {
if (legalEntity != keyLegalEntity || keySourceSystem != sourceSystem) {
MessageBox.error("Saving failed even though the request was successful", {styleClass: "sapUiSizeCompact"});
} else {
MessageToast.show("Settings saved");
that.onNavBack();
}
}
});
settingsModel.attachRequestFailed(function() {
MessageBox.error("Saving failed due to connection or ABAP system problem", {styleClass: "sapUiSizeCompact"});
});
// replacing loadData with setData
// var URIkeyUserId = encodeURIComponent(userId);
// var URIkeyLegalEntity = encodeURIComponent(keyLegalEntity);
// var URIkeySourceSystem = encodeURIComponent(keySourceSystem);
// var URI = "/sap/opu/odata/sap/ZMC_SAFI_GWPROJECT_SRV/ZMCSettingsSet(FioriUser='"+URIkeyUserId+"',LegalEntity='" + URIkeyLegalEntity + "',SourceSystem='" + URIkeySourceSystem + "')";
// settingsModel.loadData(URI);
settingsModel.setData({"FioriUser" : userId, "LegalEntity" : keyLegalEntity , "SourceSystem" : keySourceSystem} );
},
onCancelPress: function (event) {
var that = this;
this.onNavBack();
MessageToast.show("Action cancelled...");
}
});
}
);
There are no new errors in /n/IWFND/ERROR_LOG. The calls don't stop at external breakpoints in my update ABAP code or the ABAP code of the _DPC or _DPC_EXT classes (for the read they do). I tried to look at what happens with F12 in Chrome, but it doesn't tell me anything, it looks to my like setData() is called successfully and then, no idea why it doesn't work. Is some other call equivalent to submitChanges() in ODataModel needed?
You must be a registered user to add a comment. If you've already registered, sign in. Otherwise, register and sign in.